summary refs log tree commit diff
path: root/tools/testing
diff options
context:
space:
mode:
authorFlorian Fainelli <f.fainelli@gmail.com>2022-03-24 16:24:38 -0700
committerJakub Kicinski <kuba@kernel.org>2022-03-25 16:59:21 -0700
commitbf8bfc4336f7a34e48b3bbd19b1542bf085bdc3d (patch)
treeaac23a666bd97a1ae860cb7e4c9cfd827550a41e /tools/testing
parent2d327a79ee176930dc72c131a970c891d367c1dc (diff)
downloadlinux-bf8bfc4336f7a34e48b3bbd19b1542bf085bdc3d.tar.gz
net: phy: broadcom: Fix brcm_fet_config_init()
A Broadcom AC201 PHY (same entry as 5241) would be flagged by the
Broadcom UniMAC MDIO controller as not completing the turn around
properly since the PHY expects 65 MDC clock cycles to complete a write
cycle, and the MDIO controller was only sending 64 MDC clock cycles as
determined by looking at a scope shot.

This would make the subsequent read fail with the UniMAC MDIO controller
command field having MDIO_READ_FAIL set and we would abort the
brcm_fet_config_init() function and thus not probe the PHY at all.

After issuing a software reset, wait for at least 1ms which is well
above the 1us reset delay advertised by the datasheet and issue a dummy
read to let the PHY turn around the line properly. This read
specifically ignores -EIO which would be returned by MDIO controllers
checking for the line being turned around.

If we have a genuine reaad failure, the next read of the interrupt
status register would pick it up anyway.

Fixes: d7a2ed9248a3 ("broadcom: Add AC131 phy support")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Link: https://lore.kernel.org/r/20220324232438.1156812-1-f.fainelli@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'tools/testing')
0 files changed, 0 insertions, 0 deletions