summary refs log tree commit diff
path: root/tools/testing/selftests/gpio
diff options
context:
space:
mode:
authorRafael David Tinoco <rafael.tinoco@linaro.org>2018-06-06 14:44:24 -0300
committerLinus Walleij <linus.walleij@linaro.org>2018-07-09 16:08:17 +0200
commit76411a0d97c3b216ce1c987aa4afa7f3789c89d9 (patch)
treedcc9062ce1aece924fb7fc61fc602d5afcd4ca16 /tools/testing/selftests/gpio
parent8853daf3b4acb3bf8c0244a12b4f58ed5123f449 (diff)
downloadlinux-76411a0d97c3b216ce1c987aa4afa7f3789c89d9.tar.gz
gpio: selftests: gpio-mockup-chardev GPIOHANDLE_REQUEST_OUTPUT fix
Following logic from commit: 22f6592b23, GPIOHANDLE_REQUEST_OUTPUT
should handle errors same way as GPIOHANDLE_REQUEST_INPUT does, or else
the following error occurs:

gpio-mockup-chardev: gpio<gpiochip1> line<0> test flag<0x2> value<0>: No
such file or directory

despite the real result of gpio_pin_test(), gpio_debugfs_get() and
gpiotools_request_linehandle() functions.

Signed-off-by: Rafael David Tinoco <rafael.tinoco@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'tools/testing/selftests/gpio')
-rw-r--r--tools/testing/selftests/gpio/gpio-mockup-chardev.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/tools/testing/selftests/gpio/gpio-mockup-chardev.c b/tools/testing/selftests/gpio/gpio-mockup-chardev.c
index 667e916fa7cc..f8d468f54e98 100644
--- a/tools/testing/selftests/gpio/gpio-mockup-chardev.c
+++ b/tools/testing/selftests/gpio/gpio-mockup-chardev.c
@@ -225,10 +225,10 @@ int gpio_pin_test(struct gpiochip_info *cinfo, int line, int flag, int value)
 		if (flag & GPIOHANDLE_REQUEST_ACTIVE_LOW)
 			debugfs_value = !debugfs_value;
 
-		if (!(debugfs_dir == OUT && value == debugfs_value))
+		if (!(debugfs_dir == OUT && value == debugfs_value)) {
 			errno = -EINVAL;
-		ret = -errno;
-
+			ret = -errno;
+		}
 	}
 	gpiotools_release_linehandle(fd);