summary refs log tree commit diff
path: root/sound/soc
diff options
context:
space:
mode:
authorRoel Kluin <roel.kluin@gmail.com>2009-10-23 16:03:08 +0200
committerTakashi Iwai <tiwai@suse.de>2009-10-30 12:25:07 +0100
commit84ed1a1942e8c28fb4c23a6235ec48672fc43e49 (patch)
tree67b0d7a9c639cddd9cb6319ed67e0c0d6a680dd7 /sound/soc
parenta688e4885c1aa6b88ab5ffa64655bacc01749c9e (diff)
downloadlinux-84ed1a1942e8c28fb4c23a6235ec48672fc43e49.tar.gz
ALSA: Cleanup redundant tests on unsigned
The variables are unsigned so the test `>= 0' is always true,
the `< 0' test always fails. In these cases the other part of
the test catches wrapped values.

In dac_audio_write() there does not occur a test for wrapped
values, but the test appears redundant.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/soc')
-rw-r--r--sound/soc/codecs/tlv320aic23.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/soc/codecs/tlv320aic23.c b/sound/soc/codecs/tlv320aic23.c
index 0b8dcb5cd729..35606ae60868 100644
--- a/sound/soc/codecs/tlv320aic23.c
+++ b/sound/soc/codecs/tlv320aic23.c
@@ -85,7 +85,7 @@ static int tlv320aic23_write(struct snd_soc_codec *codec, unsigned int reg,
 	 * of data into val
 	 */
 
-	if ((reg < 0 || reg > 9) && (reg != 15)) {
+	if (reg > 9 && reg != 15) {
 		printk(KERN_WARNING "%s Invalid register R%u\n", __func__, reg);
 		return -1;
 	}