summary refs log tree commit diff
path: root/net/sched/sch_api.c
diff options
context:
space:
mode:
authorDavid Ahern <dsahern@gmail.com>2018-10-24 08:32:49 -0700
committerDavid S. Miller <davem@davemloft.net>2018-10-24 14:35:09 -0700
commite72bde6b66299602087c8c2350d36a525e75d06e (patch)
treeb11737432e2f68bc9624e362ce7ccf57c91fd7dc /net/sched/sch_api.c
parentac0e549678d60097793a6a818ece319e99d1ae9a (diff)
downloadlinux-e72bde6b66299602087c8c2350d36a525e75d06e.tar.gz
net: sched: Remove TCA_OPTIONS from policy
Marco reported an error with hfsc:
root@Calimero:~# tc qdisc add dev eth0 root handle 1:0 hfsc default 1
Error: Attribute failed policy validation.

Apparently a few implementations pass TCA_OPTIONS as a binary instead
of nested attribute, so drop TCA_OPTIONS from the policy.

Fixes: 8b4c3cdd9dd8 ("net: sched: Add policy validation for tc attributes")
Reported-by: Marco Berizzi <pupilla@libero.it>
Signed-off-by: David Ahern <dsahern@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sched/sch_api.c')
-rw-r--r--net/sched/sch_api.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c
index 022bca98bde6..ca3b0f46de53 100644
--- a/net/sched/sch_api.c
+++ b/net/sched/sch_api.c
@@ -1320,7 +1320,6 @@ check_loop_fn(struct Qdisc *q, unsigned long cl, struct qdisc_walker *w)
 
 const struct nla_policy rtm_tca_policy[TCA_MAX + 1] = {
 	[TCA_KIND]		= { .type = NLA_STRING },
-	[TCA_OPTIONS]		= { .type = NLA_NESTED },
 	[TCA_RATE]		= { .type = NLA_BINARY,
 				    .len = sizeof(struct tc_estimator) },
 	[TCA_STAB]		= { .type = NLA_NESTED },