diff options
author | Erik Hugne <erik.hugne@ericsson.com> | 2013-08-28 09:29:58 +0200 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2013-08-30 16:06:57 -0400 |
commit | 2c8d85182348021fc0a1bed193a4be4161dc8364 (patch) | |
tree | ef957194fcc7e49727cc687ded97df358841486c /net/8021q | |
parent | eb8895debe1baba41fcb62c78a16f0c63c21662a (diff) | |
download | linux-2c8d85182348021fc0a1bed193a4be4161dc8364.tar.gz |
tipc: set sk_err correctly when connection fails
Should a connect fail, if the publication/server is unavailable or due to some other error, a positive value will be returned and errno is never set. If the application code checks for an explicit zero return from connect (success) or a negative return (failure), it will not catch the error and subsequent send() calls will fail as shown from the strace snippet below. socket(0x1e /* PF_??? */, SOCK_SEQPACKET, 0) = 3 connect(3, {sa_family=0x1e /* AF_??? */, sa_data="\2\1\322\4\0\0\322\4\0\0\0\0\0\0"}, 16) = 111 sendto(3, "test", 4, 0, NULL, 0) = -1 EPIPE (Broken pipe) The reason for this behaviour is that TIPC wrongly inverts error codes set in sk_err. Signed-off-by: Erik Hugne <erik.hugne@ericsson.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/8021q')
0 files changed, 0 insertions, 0 deletions