diff options
author | Jiri Kosina <jkosina@suse.cz> | 2014-09-04 08:56:06 +0200 |
---|---|---|
committer | Jiri Kosina <jkosina@suse.cz> | 2014-09-04 08:56:06 +0200 |
commit | 67a97845830f79584c9db8849ac723e5d2d57f65 (patch) | |
tree | 250856471e985b57ccdc216ecd5c6f1ba9352679 /lib | |
parent | 8f507ef522d55a6e2f9e11a1c1163a92756da044 (diff) | |
download | linux-67a97845830f79584c9db8849ac723e5d2d57f65.tar.gz |
HID: thingm: fix workqueue race on remove
thingm_remove_rgb() needs to flush the workqueue after all the LED classes have been unregistered, otherwise the removal might race with another LED event coming, causing thingm_led_set() to schedule additional work after thingm_remove_rgb() has flushed it. This obviously causes oops later, as the scheduled work has been freed in the meantime. In addition to that, move the hid_hw_stop() to an earlier place, so that dmesg is not polluted by failure messages about not being able to write the LED while the device is being shut down. Reported-and-tested-by: Dylan Alex Simon <dylan-kernel@dylex.net> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'lib')
0 files changed, 0 insertions, 0 deletions