summary refs log tree commit diff
path: root/lib
diff options
context:
space:
mode:
authorJulian Braha <julianbraha@gmail.com>2022-01-17 05:09:40 +0100
committerRussell King (Oracle) <rmk+kernel@armlinux.org.uk>2022-02-21 14:58:34 +0000
commit11c57c3ba94da74c3446924260e34e0b1950b5d7 (patch)
tree0928073f1a04f3ffeec1d753be847181e48ccc8b /lib
parentd920eaa4c4559f59be7b4c2d26fa0a2e1aaa3da9 (diff)
downloadlinux-11c57c3ba94da74c3446924260e34e0b1950b5d7.tar.gz
ARM: 9178/1: fix unmet dependency on BITREVERSE for HAVE_ARCH_BITREVERSE
Resending this to properly add it to the patch tracker - thanks for letting
me know, Arnd :)

When ARM is enabled, and BITREVERSE is disabled,
Kbuild gives the following warning:

WARNING: unmet direct dependencies detected for HAVE_ARCH_BITREVERSE
  Depends on [n]: BITREVERSE [=n]
  Selected by [y]:
  - ARM [=y] && (CPU_32v7M [=n] || CPU_32v7 [=y]) && !CPU_32v6 [=n]

This is because ARM selects HAVE_ARCH_BITREVERSE
without selecting BITREVERSE, despite
HAVE_ARCH_BITREVERSE depending on BITREVERSE.

This unmet dependency bug was found by Kismet,
a static analysis tool for Kconfig. Please advise if this
is not the appropriate solution.

Signed-off-by: Julian Braha <julianbraha@gmail.com>
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Diffstat (limited to 'lib')
-rw-r--r--lib/Kconfig1
1 files changed, 0 insertions, 1 deletions
diff --git a/lib/Kconfig b/lib/Kconfig
index 5e7165e6a346..fa4b10322efc 100644
--- a/lib/Kconfig
+++ b/lib/Kconfig
@@ -45,7 +45,6 @@ config BITREVERSE
 config HAVE_ARCH_BITREVERSE
 	bool
 	default n
-	depends on BITREVERSE
 	help
 	  This option enables the use of hardware bit-reversal instructions on
 	  architectures which support such operations.