summary refs log tree commit diff
path: root/lib/test_objagg.c
diff options
context:
space:
mode:
authorAditya Pakki <pakki001@umn.edu>2020-06-12 15:01:54 -0500
committerDavid S. Miller <davem@davemloft.net>2020-06-15 13:32:11 -0700
commita6379f0ad6375a707e915518ecd5c2270afcd395 (patch)
tree42e1b1dc6f58b7899b744b4892e62cd2d921da82 /lib/test_objagg.c
parentadaff6d906d74dfe34d44fd18d5a7596d293df44 (diff)
downloadlinux-a6379f0ad6375a707e915518ecd5c2270afcd395.tar.gz
test_objagg: Fix potential memory leak in error handling
In case of failure of check_expect_hints_stats(), the resources
allocated by objagg_hints_get should be freed. The patch fixes
this issue.

Signed-off-by: Aditya Pakki <pakki001@umn.edu>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'lib/test_objagg.c')
-rw-r--r--lib/test_objagg.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/test_objagg.c b/lib/test_objagg.c
index 72c1abfa154d..da137939a410 100644
--- a/lib/test_objagg.c
+++ b/lib/test_objagg.c
@@ -979,10 +979,10 @@ err_check_expect_stats2:
 err_world2_obj_get:
 	for (i--; i >= 0; i--)
 		world_obj_put(&world2, objagg, hints_case->key_ids[i]);
-	objagg_hints_put(hints);
-	objagg_destroy(objagg2);
 	i = hints_case->key_ids_count;
+	objagg_destroy(objagg2);
 err_check_expect_hints_stats:
+	objagg_hints_put(hints);
 err_hints_get:
 err_check_expect_stats:
 err_world_obj_get: