summary refs log tree commit diff
path: root/kernel/user.c
diff options
context:
space:
mode:
authorMiklos Szeredi <mszeredi@redhat.com>2016-07-04 16:49:48 +0200
committerMiklos Szeredi <mszeredi@redhat.com>2016-07-04 16:49:48 +0200
commitb99c2d913810e56682a538c9f2394d76fca808f8 (patch)
tree01c7236cc00eafd5a9f72481ef31c5e17d34783a /kernel/user.c
parenta99cde438de0c4c0cecc1d1af1a55a75b10bfdef (diff)
downloadlinux-b99c2d913810e56682a538c9f2394d76fca808f8.tar.gz
ovl: handle ATTR_KILL*
Before 4bacc9c9234c ("overlayfs: Make f_path...") file->f_path pointed to
the underlying file, hence suid/sgid removal on write worked fine.

After that patch file->f_path pointed to the overlay file, and the file
mode bits weren't copied to overlay_inode->i_mode.  So the suid/sgid
removal simply stopped working.

The fix is to copy the mode bits, but then ovl_setattr() needs to clear
ATTR_MODE to avoid the BUG() in notify_change().  So do this first, then in
the next patch copy the mode.

Reported-by: Eryu Guan <eguan@redhat.com>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Fixes: 4bacc9c9234c ("overlayfs: Make f_path always point to the overlay and f_inode to the underlay")
Cc: <stable@vger.kernel.org>
Diffstat (limited to 'kernel/user.c')
0 files changed, 0 insertions, 0 deletions