summary refs log tree commit diff
path: root/kernel/trace/trace_nop.c
diff options
context:
space:
mode:
authorSteven Rostedt (VMware) <rostedt@goodmis.org>2018-12-09 21:17:30 -0500
committerSteven Rostedt (VMware) <rostedt@goodmis.org>2018-12-11 13:50:19 -0500
commit3cec638b3d793b7cacdec5b8072364b41caeb0e1 (patch)
treead3b1afad4a3886ff01e9d5df9227b04845822bb /kernel/trace/trace_nop.c
parentb61c19209c2c35ea2a2fe502d484703686eba98c (diff)
downloadlinux-3cec638b3d793b7cacdec5b8072364b41caeb0e1.tar.gz
tracing: Fix memory leak in set_trigger_filter()
When create_event_filter() fails in set_trigger_filter(), the filter may
still be allocated and needs to be freed. The caller expects the
data->filter to be updated with the new filter, even if the new filter
failed (we could add an error message by setting set_str parameter of
create_event_filter(), but that's another update).

But because the error would just exit, filter was left hanging and
nothing could free it.

Found by kmemleak detector.

Cc: stable@vger.kernel.org
Fixes: bac5fb97a173a ("tracing: Add and use generic set_trigger_filter() implementation")
Reviewed-by: Tom Zanussi <tom.zanussi@linux.intel.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Diffstat (limited to 'kernel/trace/trace_nop.c')
0 files changed, 0 insertions, 0 deletions