summary refs log tree commit diff
path: root/kernel/sys.c
diff options
context:
space:
mode:
authorOleg Nesterov <oleg@redhat.com>2008-11-17 15:40:08 +0100
committerIngo Molnar <mingo@elte.hu>2008-11-17 16:55:55 +0100
commit2b5fe6de58276d0b5a7c884d5dbfc300ca47db78 (patch)
tree02cc368e46a795bd2c0162d278f9c5549f4e1e5a /kernel/sys.c
parentce394471d13bf071939a9a0b48c64c297676d233 (diff)
downloadlinux-2b5fe6de58276d0b5a7c884d5dbfc300ca47db78.tar.gz
thread_group_cputime: move a couple of callsites outside of ->siglock
Impact: relax the locking of cpu-time accounting calls

->siglock buys nothing for thread_group_cputime() in do_sys_times() and
wait_task_zombie() (which btw takes the unrelated parent's ->siglock).

Actually I think do_sys_times() doesn't need ->siglock at all.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'kernel/sys.c')
-rw-r--r--kernel/sys.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/sys.c b/kernel/sys.c
index 31deba8f7d16..5fc3a0cfb994 100644
--- a/kernel/sys.c
+++ b/kernel/sys.c
@@ -858,8 +858,8 @@ void do_sys_times(struct tms *tms)
 	struct task_cputime cputime;
 	cputime_t cutime, cstime;
 
-	spin_lock_irq(&current->sighand->siglock);
 	thread_group_cputime(current, &cputime);
+	spin_lock_irq(&current->sighand->siglock);
 	cutime = current->signal->cutime;
 	cstime = current->signal->cstime;
 	spin_unlock_irq(&current->sighand->siglock);