diff options
| author | Vasily Averin <vvs@virtuozzo.com> | 2020-01-30 13:34:49 +0300 |
|---|---|---|
| committer | Tejun Heo <tj@kernel.org> | 2020-02-12 16:53:35 -0500 |
| commit | db8dd9697238be70a6b4f9d0284cd89f59c0e070 (patch) | |
| tree | 45be3ce2a75ac854098801530b41d4609858f67b /kernel/cgroup | |
| parent | 0bf999f9c5e74c7ecf9dafb527146601e5c848b9 (diff) | |
| download | linux-db8dd9697238be70a6b4f9d0284cd89f59c0e070.tar.gz | |
cgroup-v1: cgroup_pidlist_next should update position index
if seq_file .next fuction does not change position index, read after some lseek can generate unexpected output. # mount | grep cgroup # dd if=/mnt/cgroup.procs bs=1 # normal output ... 1294 1295 1296 1304 1382 584+0 records in 584+0 records out 584 bytes copied dd: /mnt/cgroup.procs: cannot skip to specified offset 83 <<< generates end of last line 1383 <<< ... and whole last line once again 0+1 records in 0+1 records out 8 bytes copied dd: /mnt/cgroup.procs: cannot skip to specified offset 1386 <<< generates last line anyway 0+1 records in 0+1 records out 5 bytes copied https://bugzilla.kernel.org/show_bug.cgi?id=206283 Signed-off-by: Vasily Averin <vvs@virtuozzo.com> Signed-off-by: Tejun Heo <tj@kernel.org>
Diffstat (limited to 'kernel/cgroup')
| -rw-r--r-- | kernel/cgroup/cgroup-v1.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/kernel/cgroup/cgroup-v1.c b/kernel/cgroup/cgroup-v1.c index be1a1c83cdd1..9a6f060cbf51 100644 --- a/kernel/cgroup/cgroup-v1.c +++ b/kernel/cgroup/cgroup-v1.c @@ -471,6 +471,7 @@ static void *cgroup_pidlist_next(struct seq_file *s, void *v, loff_t *pos) */ p++; if (p >= end) { + (*pos)++; return NULL; } else { *pos = *p; |