diff options
| author | Dmitry Monakhov <dmonakhov@openvz.org> | 2013-04-01 11:00:00 +0400 |
|---|---|---|
| committer | Eric Paris <eparis@redhat.com> | 2013-04-10 13:21:52 -0400 |
| commit | 65ada7bc02e2dcea6dea1f11876e712d5ea7e9ba (patch) | |
| tree | 26cb09addd5656bc6e9806834e41097683f5ae40 /kernel/auditsc.c | |
| parent | 2540334adc1c7241a7f91a9cf7ec56776d3f601b (diff) | |
| download | linux-65ada7bc02e2dcea6dea1f11876e712d5ea7e9ba.tar.gz | |
audit: destroy long filenames correctly
filename should be destroyed via final_putname() instead of __putname() Otherwise this result in following BUGON() in case of long names: kernel BUG at mm/slab.c:3006! Call Trace: kmem_cache_free+0x1c1/0x850 audit_putname+0x88/0x90 putname+0x73/0x80 sys_symlinkat+0x120/0x150 sys_symlink+0x16/0x20 system_call_fastpath+0x16/0x1b Introduced-in: 7950e3852 Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org> Reviewed-by: Jeff Layton <jlayton@redhat.com> Signed-off-by: Eric Paris <eparis@redhat.com>
Diffstat (limited to 'kernel/auditsc.c')
| -rw-r--r-- | kernel/auditsc.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/kernel/auditsc.c b/kernel/auditsc.c index 77c705c302f7..b59ffb293ded 100644 --- a/kernel/auditsc.c +++ b/kernel/auditsc.c @@ -1024,7 +1024,7 @@ static inline void audit_free_names(struct audit_context *context) list_for_each_entry_safe(n, next, &context->names_list, list) { list_del(&n->list); if (n->name && n->name_put) - __putname(n->name); + final_putname(n->name); if (n->should_free) kfree(n); } @@ -2050,7 +2050,7 @@ void audit_putname(struct filename *name) BUG_ON(!context); if (!context->in_syscall) { #if AUDIT_DEBUG == 2 - printk(KERN_ERR "%s:%d(:%d): __putname(%p)\n", + printk(KERN_ERR "%s:%d(:%d): final_putname(%p)\n", __FILE__, __LINE__, context->serial, name); if (context->name_count) { struct audit_names *n; @@ -2061,7 +2061,7 @@ void audit_putname(struct filename *name) n->name, n->name->name ?: "(null)"); } #endif - __putname(name); + final_putname(name); } #if AUDIT_DEBUG else { |