diff options
author | Daniel Thompson <daniel.thompson@linaro.org> | 2022-01-27 17:35:54 +0000 |
---|---|---|
committer | Bjorn Andersson <bjorn.andersson@linaro.org> | 2022-01-31 18:12:20 -0600 |
commit | 8030cb9a55688c1339edd284d9d6ce5f9fc75160 (patch) | |
tree | fb6bd6fe20c80f931af12fb397ca5dccd3ab2c3e /ipc | |
parent | 4e6ae78ee61957800657d56ba78a10f034de174e (diff) | |
download | linux-8030cb9a55688c1339edd284d9d6ce5f9fc75160.tar.gz |
soc: qcom: aoss: remove spurious IRQF_ONESHOT flags
Quoting the header comments, IRQF_ONESHOT is "Used by threaded interrupts which need to keep the irq line disabled until the threaded handler has been run.". When applied to an interrupt that doesn't request a threaded irq then IRQF_ONESHOT has a lesser known (undocumented?) side effect, which it to disable the forced threading of the irq. For "normal" kernels (without forced threading) then, if there is no thread_fn, then IRQF_ONESHOT is a nop. In this case disabling forced threading is not appropriate for this driver because it calls wake_up_all() and this API cannot be called from no-thread interrupt handlers on PREEMPT_RT systems (deadlock risk, triggers sleeping-while-atomic warnings). Fix this by removing IRQF_ONESHOT. Fixes: 2209481409b7 ("soc: qcom: Add AOSS QMP driver") Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org> [bjorn: Added Fixes tag] Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> Link: https://lore.kernel.org/r/20220127173554.158111-1-daniel.thompson@linaro.org
Diffstat (limited to 'ipc')
0 files changed, 0 insertions, 0 deletions