summary refs log tree commit diff
path: root/include/asm-s390/ccwdev.h
diff options
context:
space:
mode:
authorGerrit Renker <gerrit@erg.abdn.ac.uk>2007-10-24 10:53:01 -0200
committerArnaldo Carvalho de Melo <acme@ghostprotocols.net>2007-10-24 10:53:01 -0200
commit24c667db59a9cc4caaafe4f77f6f4ef85899a454 (patch)
tree9470e271eb74375c79aad804d7400644e3762cca /include/asm-s390/ccwdev.h
parent76fd1e87d9456c8185b8df76ac5e533e0c8b39bb (diff)
downloadlinux-24c667db59a9cc4caaafe4f77f6f4ef85899a454.tar.gz
[CCID2/3]: Initialisation assignments of 0 are redundant
Assigning initial values of `0' is redundant when loading a new CCID structure,
since in net/dccp/ccid.c the entire CCID structure is zeroed out prior to
initialisation in ccid_new():

    	struct ccid {
    		struct ccid_operations *ccid_ops;
    		char		       ccid_priv[0];
    	};

    	// ...
    	if (rx) {
    		memset(ccid + 1, 0, ccid_ops->ccid_hc_rx_obj_size);
    		if (ccid->ccid_ops->ccid_hc_rx_init != NULL &&
    		    ccid->ccid_ops->ccid_hc_rx_init(ccid, sk) != 0)
    			goto out_free_ccid;
    	} else {
    		memset(ccid + 1, 0, ccid_ops->ccid_hc_tx_obj_size);
    		/* analogous to the rx case */
    	}

This patch therefore removes the redundant assignments. Thanks to Arnaldo for
the inspiration.

Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Signed-off-by: Ian McDonald <ian.mcdonald@jandi.co.nz>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'include/asm-s390/ccwdev.h')
0 files changed, 0 insertions, 0 deletions