summary refs log tree commit diff
path: root/fs
diff options
context:
space:
mode:
authorSven Schnelle <svens@stackframe.org>2008-04-02 13:17:18 +0100
committerLinus Torvalds <torvalds@linux-foundation.org>2008-04-02 07:40:54 -0700
commita5f37c3252b174efdcdd808797a7c529064c95c0 (patch)
tree8932c50a54cdbeb1fadda70f388bbc53d6407d9c /fs
parent0e81a8ae37687845f7cdfa2adce14ea6a5f1dd34 (diff)
downloadlinux-a5f37c3252b174efdcdd808797a7c529064c95c0.tar.gz
afs: add missing up_write() on return
If afs_cell_alloc() fails, afs_cells_sem doesn't get unlocked, which
leads to a deadlock.  Unlock it before returning.

Signed-off-by: Sven Schnelle <svens@stackframe.org>
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs')
-rw-r--r--fs/afs/cell.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/afs/cell.c b/fs/afs/cell.c
index 788865df1bc9..584bb0f9c36a 100644
--- a/fs/afs/cell.c
+++ b/fs/afs/cell.c
@@ -138,6 +138,7 @@ struct afs_cell *afs_cell_create(const char *name, char *vllist)
 	cell = afs_cell_alloc(name, vllist);
 	if (IS_ERR(cell)) {
 		_leave(" = %ld", PTR_ERR(cell));
+		up_write(&afs_cells_sem);
 		return cell;
 	}