diff options
author | Christian Brauner <brauner@kernel.org> | 2023-06-13 10:13:37 +0200 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2023-07-27 08:50:32 +0200 |
commit | cce9107c315f564784f18fab18d2c20ab888d262 (patch) | |
tree | de16597535d715adf33d71a719f20c93dadd3a15 /fs/udf/unicode.c | |
parent | 5228d4d505288c292be1f9fb2c73261946a6b3a5 (diff) | |
download | linux-cce9107c315f564784f18fab18d2c20ab888d262.tar.gz |
ovl: check type and offset of struct vfsmount in ovl_entry
[ Upstream commit f723edb8a532cd26e1ff0a2b271d73762d48f762 ] Porting overlayfs to the new amount api I started experiencing random crashes that couldn't be explained easily. So after much debugging and reasoning it became clear that struct ovl_entry requires the point to struct vfsmount to be the first member and of type struct vfsmount. During the port I added a new member at the beginning of struct ovl_entry which broke all over the place in the form of random crashes and cache corruptions. While there's a comment in ovl_free_fs() to the effect of "Hack! Reuse ofs->layers as a vfsmount array before freeing it" there's no such comment on struct ovl_entry which makes this easy to trip over. Add a comment and two static asserts for both the offset and the type of pointer in struct ovl_entry. Signed-off-by: Christian Brauner <brauner@kernel.org> Signed-off-by: Amir Goldstein <amir73il@gmail.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'fs/udf/unicode.c')
0 files changed, 0 insertions, 0 deletions