summary refs log tree commit diff
path: root/fs/udf/super.c
diff options
context:
space:
mode:
authorPali Rohár <pali.rohar@gmail.com>2020-01-12 23:13:53 +0100
committerJan Kara <jack@suse.cz>2020-01-13 12:38:46 +0100
commit49be68c4931d9f0f171e5f01a574fc40205db2b5 (patch)
treeb165a3452f1b66c802cd5073311802eb5038fb46 /fs/udf/super.c
parenta4a8b99ec819ca60b49dc582a4287ef03411f117 (diff)
downloadlinux-49be68c4931d9f0f171e5f01a574fc40205db2b5.tar.gz
udf: Fix meaning of ENTITYID_FLAGS_* macros to be really bitwise-or flags
Currently ENTITYID_FLAGS_* macros definitions are written as hex numbers
but their meaning is not bitwise-or flags. But rather bit position. This is
unusual and could be misleading. So change meaning of ENTITYID_FLAGS_*
macros definitions to be really bitwise-or flags.

Link: https://lore.kernel.org/r/20200112221353.29711-1-pali.rohar@gmail.com
Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
Signed-off-by: Jan Kara <jack@suse.cz>
Diffstat (limited to 'fs/udf/super.c')
-rw-r--r--fs/udf/super.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/udf/super.c b/fs/udf/super.c
index 5a4a6fb36819..0311c7decdd2 100644
--- a/fs/udf/super.c
+++ b/fs/udf/super.c
@@ -773,7 +773,7 @@ static int udf_verify_domain_identifier(struct super_block *sb,
 		udf_warn(sb, "Not OSTA UDF compliant %s descriptor.\n", dname);
 		goto force_ro;
 	}
-	if (ident->flags & (1 << ENTITYID_FLAGS_DIRTY)) {
+	if (ident->flags & ENTITYID_FLAGS_DIRTY) {
 		udf_warn(sb, "Possibly not OSTA UDF compliant %s descriptor.\n",
 			 dname);
 		goto force_ro;