summary refs log tree commit diff
path: root/fs/pstore/ram_core.c
diff options
context:
space:
mode:
authorKees Cook <keescook@chromium.org>2018-11-01 14:03:07 -0700
committerKees Cook <keescook@chromium.org>2018-12-03 16:52:35 -0800
commit0eed84ffb094bbddfb4b9378ef0a2eccf4dda99c (patch)
tree67a4d68cf26f25dde588702cb4ed4f905436e91b /fs/pstore/ram_core.c
parentc208f7d4b037e1c71e5c839bb5dfcc3e0df19890 (diff)
downloadlinux-0eed84ffb094bbddfb4b9378ef0a2eccf4dda99c.tar.gz
pstore: Improve and update some comments and status output
This improves and updates some comments:
 - dump handler comment out of sync from calling convention
 - fix kern-doc typo

and improves status output:
 - reminder that only kernel crash dumps are compressed
 - do not be silent about ECC infrastructure failures

Signed-off-by: Kees Cook <keescook@chromium.org>
Diffstat (limited to 'fs/pstore/ram_core.c')
-rw-r--r--fs/pstore/ram_core.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/fs/pstore/ram_core.c b/fs/pstore/ram_core.c
index 3e9e3ba4fb07..e6375439c5ac 100644
--- a/fs/pstore/ram_core.c
+++ b/fs/pstore/ram_core.c
@@ -503,8 +503,10 @@ static int persistent_ram_post_init(struct persistent_ram_zone *prz, u32 sig,
 	bool zap = !!(prz->flags & PRZ_FLAG_ZAP_OLD);
 
 	ret = persistent_ram_init_ecc(prz, ecc_info);
-	if (ret)
+	if (ret) {
+		pr_warn("ECC failed %s\n", prz->label);
 		return ret;
+	}
 
 	sig ^= PERSISTENT_RAM_SIG;