summary refs log tree commit diff
path: root/fs/proc
diff options
context:
space:
mode:
authorEric W. Biederman <ebiederm@xmission.com>2020-11-20 17:14:22 -0600
committerEric W. Biederman <ebiederm@xmission.com>2020-12-10 12:39:44 -0600
commitb48845af0152d790a54b8ab78cc2b7c07485fc98 (patch)
tree1e2620306583bc904cb9bbf946f54d8f384d274d /fs/proc
parentf43c283a89a7dc531a47d4b1e001503cf3dc3234 (diff)
downloadlinux-b48845af0152d790a54b8ab78cc2b7c07485fc98.tar.gz
bpf: In bpf_task_fd_query use fget_task
Use the helper fget_task to simplify bpf_task_fd_query.

As well as simplifying the code this removes one unnecessary increment of
struct files_struct.  This unnecessary increment of files_struct.count can
result in exec unnecessarily unsharing files_struct and breaking posix
locks, and it can result in fget_light having to fallback to fget reducing
performance.

This simplification comes from the observation that none of the
callers of get_files_struct actually need to call get_files_struct
that was made when discussing[1] exec and posix file locks.

[1] https://lkml.kernel.org/r/20180915160423.GA31461@redhat.com
Suggested-by: Oleg Nesterov <oleg@redhat.com>
v1: https://lkml.kernel.org/r/20200817220425.9389-5-ebiederm@xmission.com
Link: https://lkml.kernel.org/r/20201120231441.29911-5-ebiederm@xmission.com
Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Diffstat (limited to 'fs/proc')
0 files changed, 0 insertions, 0 deletions