summary refs log tree commit diff
path: root/fs/pnode.c
diff options
context:
space:
mode:
authorFilipe Manana <fdmanana@suse.com>2020-04-17 16:36:50 +0100
committerDavid Sterba <dsterba@suse.com>2020-05-25 11:25:24 +0200
commit534cf531ccf6331b6e63a054f2ceb8e1ccff1ec9 (patch)
treedadd308b1cbd00c7d4c3cfea27845330a3f4e04b /fs/pnode.c
parente3b8336117e515a260da32fa10bb3354ba12c429 (diff)
downloadlinux-534cf531ccf6331b6e63a054f2ceb8e1ccff1ec9.tar.gz
btrfs: simplify error handling of clean_pinned_extents()
At clean_pinned_extents(), whether we end up returning success or failure,
we pretty much have to do the same things:

1) unlock unused_bg_unpin_mutex
2) decrement reference count on the previous transaction

We also call btrfs_dec_block_group_ro() in case of failure, but that is
better done in its caller, btrfs_delete_unused_bgs(), since its the
caller that calls inc_block_group_ro(), so it should be responsible for
the decrement operation, as it is in case any of the other functions it
calls fail.

So move the call to btrfs_dec_block_group_ro() from clean_pinned_extents()
into  btrfs_delete_unused_bgs() and unify the error and success return
paths for clean_pinned_extents(), reducing duplicated code and making it
simpler.

Signed-off-by: Filipe Manana <fdmanana@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/pnode.c')
0 files changed, 0 insertions, 0 deletions