diff options
| author | J. Bruce Fields <bfields@redhat.com> | 2017-04-21 15:26:30 -0400 |
|---|---|---|
| committer | J. Bruce Fields <bfields@redhat.com> | 2017-04-25 16:36:23 -0400 |
| commit | 13bf9fbff0e5e099e2b6f003a0ab8ae145436309 (patch) | |
| tree | 950c4317be5f1138b1659aaa535de228ea51c36c /fs/nfsd/nfsxdr.c | |
| parent | db44bac41bbfc0c0d9dd943092d8bded3c9db19b (diff) | |
| download | linux-13bf9fbff0e5e099e2b6f003a0ab8ae145436309.tar.gz | |
nfsd: stricter decoding of write-like NFSv2/v3 ops
The NFSv2/v3 code does not systematically check whether we decode past the end of the buffer. This generally appears to be harmless, but there are a few places where we do arithmetic on the pointers involved and don't account for the possibility that a length could be negative. Add checks to catch these. Reported-by: Tuomas Haanpää <thaan@synopsys.com> Reported-by: Ari Kauppi <ari@synopsys.com> Reviewed-by: NeilBrown <neilb@suse.com> Cc: stable@vger.kernel.org Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Diffstat (limited to 'fs/nfsd/nfsxdr.c')
| -rw-r--r-- | fs/nfsd/nfsxdr.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/nfsd/nfsxdr.c b/fs/nfsd/nfsxdr.c index 59bd88a23a3d..de07ff625777 100644 --- a/fs/nfsd/nfsxdr.c +++ b/fs/nfsd/nfsxdr.c @@ -302,6 +302,8 @@ nfssvc_decode_writeargs(struct svc_rqst *rqstp, __be32 *p, * bytes. */ hdr = (void*)p - head->iov_base; + if (hdr > head->iov_len) + return 0; dlen = head->iov_len + rqstp->rq_arg.page_len - hdr; /* |