summary refs log tree commit diff
path: root/fs/fuse/inode.c
diff options
context:
space:
mode:
authorGreg Kurz <groug@kaod.org>2021-06-04 18:11:54 +0200
committerMiklos Szeredi <mszeredi@redhat.com>2021-06-22 09:15:35 +0200
commit266eb3f2fae488fd19ee5acfc01ba9d483715699 (patch)
tree8b775cbd04f2ea083f1ee0ef4f437d7fd341753a /fs/fuse/inode.c
parentfe0a7bd81bfefe5eb73bce55682586c6c266e21e (diff)
downloadlinux-266eb3f2fae488fd19ee5acfc01ba9d483715699.tar.gz
fuse: Call vfs_get_tree() for submounts
We recently fixed an infinite loop by setting the SB_BORN flag on
submounts along with the write barrier needed by super_cache_count().
This is the job of vfs_get_tree() and FUSE shouldn't have to care
about the barrier at all.

Split out some code from fuse_dentry_automount() to the dedicated
fuse_get_tree_submount() handler for submounts and call vfs_get_tree().

Signed-off-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Diffstat (limited to 'fs/fuse/inode.c')
-rw-r--r--fs/fuse/inode.c36
1 files changed, 36 insertions, 0 deletions
diff --git a/fs/fuse/inode.c b/fs/fuse/inode.c
index a0a8228979a2..c7aee88ce7aa 100644
--- a/fs/fuse/inode.c
+++ b/fs/fuse/inode.c
@@ -1353,8 +1353,44 @@ int fuse_fill_super_submount(struct super_block *sb,
 	return 0;
 }
 
+/* Filesystem context private data holds the FUSE inode of the mount point */
 static int fuse_get_tree_submount(struct fs_context *fsc)
 {
+	struct fuse_mount *fm;
+	struct fuse_inode *mp_fi = fsc->fs_private;
+	struct fuse_conn *fc = get_fuse_conn(&mp_fi->inode);
+	struct super_block *sb;
+	int err;
+
+	fm = kzalloc(sizeof(struct fuse_mount), GFP_KERNEL);
+	if (!fm)
+		return -ENOMEM;
+
+	fsc->s_fs_info = fm;
+	sb = sget_fc(fsc, NULL, set_anon_super_fc);
+	if (IS_ERR(sb)) {
+		kfree(fm);
+		return PTR_ERR(sb);
+	}
+	fm->fc = fuse_conn_get(fc);
+
+	/* Initialize superblock, making @mp_fi its root */
+	err = fuse_fill_super_submount(sb, mp_fi);
+	if (err) {
+		fuse_conn_put(fc);
+		kfree(fm);
+		sb->s_fs_info = NULL;
+		deactivate_locked_super(sb);
+		return err;
+	}
+
+	down_write(&fc->killsb);
+	list_add_tail(&fm->fc_entry, &fc->mounts);
+	up_write(&fc->killsb);
+
+	sb->s_flags |= SB_ACTIVE;
+	fsc->root = dget(sb->s_root);
+
 	return 0;
 }