summary refs log tree commit diff
path: root/fs/ecryptfs/file.c
diff options
context:
space:
mode:
authorJulia Lawall <julia@diku.dk>2010-01-16 17:00:26 +0100
committerTyler Hicks <tyhicks@linux.vnet.ibm.com>2010-01-19 22:36:05 -0600
commit4aa25bcb7dac2d583f1557e2be2d0b598581da54 (patch)
tree6627afceaed30b0897298e83ceb4ecd580eeb9f0 /fs/ecryptfs/file.c
parentfe0fc013cd8bbd2f4737c1b2694b37dd7fe459cb (diff)
downloadlinux-4aa25bcb7dac2d583f1557e2be2d0b598581da54.tar.gz
ecryptfs: Eliminate useless code
The variable lower_dentry is initialized twice to the same (side effect-free)
expression.  Drop one initialization.

A simplified version of the semantic match that finds this problem is:
(http://coccinelle.lip6.fr/)

// <smpl>
@forall@
idexpression *x;
identifier f!=ERR_PTR;
@@

x = f(...)
... when != x
(
x = f(...,<+...x...+>,...)
|
* x = f(...)
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Tyler Hicks <tyhicks@linux.vnet.ibm.com>
Diffstat (limited to 'fs/ecryptfs/file.c')
-rw-r--r--fs/ecryptfs/file.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/ecryptfs/file.c b/fs/ecryptfs/file.c
index dde7bb48bb5f..678172b61be2 100644
--- a/fs/ecryptfs/file.c
+++ b/fs/ecryptfs/file.c
@@ -158,7 +158,7 @@ static int ecryptfs_open(struct inode *inode, struct file *file)
 	struct dentry *ecryptfs_dentry = file->f_path.dentry;
 	/* Private value of ecryptfs_dentry allocated in
 	 * ecryptfs_lookup() */
-	struct dentry *lower_dentry = ecryptfs_dentry_to_lower(ecryptfs_dentry);
+	struct dentry *lower_dentry;
 	struct ecryptfs_file_info *file_info;
 
 	mount_crypt_stat = &ecryptfs_superblock_to_private(