diff options
| author | Josef Bacik <jbacik@fb.com> | 2014-09-18 11:27:17 -0400 |
|---|---|---|
| committer | Chris Mason <clm@fb.com> | 2014-09-22 17:13:31 -0700 |
| commit | f6acfd50110b335c7af636cf1fc8e55319cae5fc (patch) | |
| tree | cfd2993ba149a853872ab7b50ffad9b7a0ed21e6 /fs/btrfs | |
| parent | 47ab2a6c689913db23ccae38349714edf8365e0a (diff) | |
| download | linux-f6acfd50110b335c7af636cf1fc8e55319cae5fc.tar.gz | |
Btrfs: don't do async reclaim during log replay
Trying to reproduce a log enospc bug I hit a panic in the async reclaim code during log replay. This is because we use fs_info->fs_root as our root for shrinking and such. Technically we can use whatever root we want, but let's just not allow async reclaim while we're doing log replay. Thanks, Signed-off-by: Josef Bacik <jbacik@fb.com> Signed-off-by: Chris Mason <clm@fb.com>
Diffstat (limited to 'fs/btrfs')
| -rw-r--r-- | fs/btrfs/extent-tree.c | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c index 28a27d5f02d3..44d04979f071 100644 --- a/fs/btrfs/extent-tree.c +++ b/fs/btrfs/extent-tree.c @@ -4513,7 +4513,13 @@ again: space_info->flush = 1; } else if (!ret && space_info->flags & BTRFS_BLOCK_GROUP_METADATA) { used += orig_bytes; - if (need_do_async_reclaim(space_info, root->fs_info, used) && + /* + * We will do the space reservation dance during log replay, + * which means we won't have fs_info->fs_root set, so don't do + * the async reclaim as we will panic. + */ + if (!root->fs_info->log_root_recovering && + need_do_async_reclaim(space_info, root->fs_info, used) && !work_busy(&root->fs_info->async_reclaim_work)) queue_work(system_unbound_wq, &root->fs_info->async_reclaim_work); |