summary refs log tree commit diff
path: root/fs/btrfs/relocation.c
diff options
context:
space:
mode:
authorJulia Lawall <julia@diku.dk>2011-01-24 19:55:19 +0000
committerChris Mason <chris.mason@oracle.com>2011-01-28 16:40:37 -0500
commit34d19bada00f4825588b338a8ee193820f9ceeb0 (patch)
tree878be53a548cfc3b2bf653ab33f4431691ca9646 /fs/btrfs/relocation.c
parent333e8105445d4f51101fc3d23199a919d66730b3 (diff)
downloadlinux-34d19bada00f4825588b338a8ee193820f9ceeb0.tar.gz
fs/btrfs/inode.c: Add missing IS_ERR test
After the conditional that precedes the following code, inode may be an
ERR_PTR value.  This can eg result from a memory allocation failure via the
call to btrfs_iget, and thus does not imply that root is different than
sub_root.  Thus, an IS_ERR check is added to ensure that there is no
dereference of inode in this case.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r@
identifier f;
@@
f(...) { ... return ERR_PTR(...); }

@@
identifier r.f, fld;
expression x;
statement S1,S2;
@@
 x = f(...)
 ... when != IS_ERR(x)
(
 if (IS_ERR(x) ||...) S1 else S2
|
*x->fld
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Chris Mason <chris.mason@oracle.com>
Diffstat (limited to 'fs/btrfs/relocation.c')
0 files changed, 0 insertions, 0 deletions