summary refs log tree commit diff
path: root/firmware/bnx2
diff options
context:
space:
mode:
authorMichal Hocko <mhocko@suse.cz>2014-08-29 15:18:42 -0700
committerLinus Torvalds <torvalds@linux-foundation.org>2014-08-29 16:28:16 -0700
commit7ea8574e5fa31f43d8098a028f12ba6a9c9f3530 (patch)
treeb9209f9a97424e987bd0abe1b22abd2fb0e0da05 /firmware/bnx2
parent137f8cff505ace6251dc442c7aa973d60c801a79 (diff)
downloadlinux-7ea8574e5fa31f43d8098a028f12ba6a9c9f3530.tar.gz
hugetlb_cgroup: use lockdep_assert_held rather than spin_is_locked
spin_lock may be an empty struct for !SMP configurations and so
arch_spin_is_locked may return unconditional 0 and trigger the VM_BUG_ON
even when the lock is held.

Replace spin_is_locked by lockdep_assert_held.  We will not BUG anymore
but it is questionable whether crashing makes a lot of sense in the
uncharge path.  Uncharge happens after the last page reference was
released so nobody should touch the page and the function doesn't update
any shared state except for res counter which uses synchronization of
its own.

Signed-off-by: Michal Hocko <mhocko@suse.cz>
Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'firmware/bnx2')
0 files changed, 0 insertions, 0 deletions