diff options
| author | Arnd Bergmann <arnd@arndb.de> | 2013-01-25 14:14:26 +0000 |
|---|---|---|
| committer | Samuel Ortiz <sameo@linux.intel.com> | 2013-01-27 02:18:01 +0100 |
| commit | f65e9eacfad60cd05d1bac7defb6ff6b50dcfb5b (patch) | |
| tree | 5d44d49b4b471f5aa715549298bce6128a10830f /drivers | |
| parent | 0a8c290ac58a86d5e1f2193abcd4d74ec075e20c (diff) | |
| download | linux-f65e9eacfad60cd05d1bac7defb6ff6b50dcfb5b.tar.gz | |
mfd: twl4030: Don't warn about uninitialized return code
If the twl4030_write_script function gets called with a zero length argument, its return value does not get set. We know that all scripts have a nonzero length, but returning an error in case they ever do is probably appropriate. Without this patch, building omap2plus_defconfig results in: drivers/mfd/twl4030-power.c: In function 'load_twl4030_script': drivers/mfd/twl4030-power.c:414:5: error: 'err' may be used uninitialized in this function Signed-off-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: Peter Ujfalusi <peter.ujfalusi@ti.com> Reviewed-by: Amit Kucheria <amit.kucheria@linaro.org> Cc: Kevin Hilman <khilman@deeprootsystems.com> Cc: "Kristo, Tero" <t-kristo@ti.com> Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/mfd/twl4030-power.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c index 4dae241e5017..dd362c1078e1 100644 --- a/drivers/mfd/twl4030-power.c +++ b/drivers/mfd/twl4030-power.c @@ -159,7 +159,7 @@ out: static int twl4030_write_script(u8 address, struct twl4030_ins *script, int len) { - int err; + int err = -EINVAL; for (; len; len--, address++, script++) { if (len == 1) { |