diff options
| author | Hannes Reinecke <hare@suse.de> | 2022-08-24 09:23:16 +0200 |
|---|---|---|
| committer | Christoph Hellwig <hch@lst.de> | 2022-08-31 07:57:59 +0300 |
| commit | da0342a3aa0357795224e6283df86444e1117168 (patch) | |
| tree | 9239e963ecf14fd10f0df4a8c554902ea551e316 /drivers | |
| parent | 200dccd07df21b504a2168960059f0a971bf415d (diff) | |
| download | linux-da0342a3aa0357795224e6283df86444e1117168.tar.gz | |
nvmet-auth: add missing goto in nvmet_setup_auth()
There's a goto missing in nvmet_setup_auth(), causing a kernel oops when nvme_auth_extract_key() fails. Reported-by: Tal Lossos <tallossos@gmail.com> Signed-off-by: Hannes Reinecke <hare@suse.de> Reviewed-by: Sagi Grimberg <sagi@grimberg.me> Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com> Signed-off-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/nvme/target/auth.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/nvme/target/auth.c b/drivers/nvme/target/auth.c index cf690df34775..c4113b43dbfe 100644 --- a/drivers/nvme/target/auth.c +++ b/drivers/nvme/target/auth.c @@ -196,6 +196,7 @@ int nvmet_setup_auth(struct nvmet_ctrl *ctrl) if (IS_ERR(ctrl->ctrl_key)) { ret = PTR_ERR(ctrl->ctrl_key); ctrl->ctrl_key = NULL; + goto out_free_hash; } pr_debug("%s: using ctrl hash %s key %*ph\n", __func__, ctrl->ctrl_key->hash > 0 ? |