summary refs log tree commit diff
path: root/drivers
diff options
context:
space:
mode:
authorMatias Bjørling <m@bjorling.me>2015-11-20 13:47:54 +0100
committerJens Axboe <axboe@fb.com>2015-11-20 08:33:16 -0700
commit93e70c1f2883f2db2d6a1f339d0e26f00b138e4e (patch)
treea85eb5d1f16e4533ae52b5b36be06ebf59bf5dcb /drivers
parent480fc0db819d706ea5608545a12d33cf8d5a31ab (diff)
downloadlinux-93e70c1f2883f2db2d6a1f339d0e26f00b138e4e.tar.gz
lightnvm: missing free on init error
If either max_phys_sect is out of bound, the nvm_dev structure is not
freed.

Signed-off-by: Matias Bjørling <m@bjorling.me>
Signed-off-by: Jens Axboe <axboe@fb.com>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/lightnvm/core.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/drivers/lightnvm/core.c b/drivers/lightnvm/core.c
index bed47e7249a9..f61d325fd978 100644
--- a/drivers/lightnvm/core.c
+++ b/drivers/lightnvm/core.c
@@ -313,11 +313,13 @@ int nvm_register(struct request_queue *q, char *disk_name,
 								"ppalist");
 		if (!dev->ppalist_pool) {
 			pr_err("nvm: could not create ppa pool\n");
-			return -ENOMEM;
+			ret = -ENOMEM;
+			goto err_init;
 		}
 	} else if (dev->ops->max_phys_sect > 256) {
 		pr_info("nvm: max sectors supported is 256.\n");
-		return -EINVAL;
+		ret = -EINVAL;
+		goto err_init;
 	}
 
 	down_write(&nvm_lock);