diff options
| author | Yang Yingliang <yangyingliang@huawei.com> | 2021-06-26 12:44:19 +0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2021-06-28 14:20:22 -0700 |
| commit | 8f4c38f7588650690ffa08f7784c831e0a8c38e7 (patch) | |
| tree | b6df2cda795424945ccf611123117295d226fcec /drivers | |
| parent | f00af5cc58ec5aae83ce4860e4912d61fb143d5e (diff) | |
| download | linux-8f4c38f7588650690ffa08f7784c831e0a8c38e7.tar.gz | |
net: sparx5: fix return value check in sparx5_create_targets()
In case of error, the function devm_ioremap() returns NULL pointer
not ERR_PTR(). The IS_ERR() test in the return value check should
be replaced with NULL test.
Fixes: 3cfa11bac9bb ("net: sparx5: add the basic sparx5 driver")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/ethernet/microchip/sparx5/sparx5_main.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/ethernet/microchip/sparx5/sparx5_main.c b/drivers/net/ethernet/microchip/sparx5/sparx5_main.c index 665e20ccb404..abaa086ce345 100644 --- a/drivers/net/ethernet/microchip/sparx5/sparx5_main.c +++ b/drivers/net/ethernet/microchip/sparx5/sparx5_main.c @@ -236,10 +236,10 @@ static int sparx5_create_targets(struct sparx5 *sparx5) iores[idx]->start, iores[idx]->end - iores[idx]->start + 1); - if (IS_ERR(iomem[idx])) { + if (!iomem[idx]) { dev_err(sparx5->dev, "Unable to get switch registers: %s\n", iores[idx]->name); - return PTR_ERR(iomem[idx]); + return -ENOMEM; } begin[idx] = iomem[idx] - sparx5_main_iomap[range_id[idx]].offset; } |