summary refs log tree commit diff
path: root/drivers
diff options
context:
space:
mode:
authorMarkus Elfring <elfring@users.sourceforge.net>2014-11-21 12:40:32 +0100
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2014-11-26 19:35:49 -0800
commit48f5cde566201f987125ec783f40dc84b69ce300 (patch)
tree6b1215215072440faf8689bfccc93eface0f5b5d /drivers
parenta211b1af1933a3b6019d985762f5237d1d4c4213 (diff)
downloadlinux-48f5cde566201f987125ec783f40dc84b69ce300.tar.gz
tty-hvsi_lib: Deletion of an unnecessary check before the function call "tty_kref_put"
The tty_kref_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/tty/hvc/hvsi_lib.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/tty/hvc/hvsi_lib.c b/drivers/tty/hvc/hvsi_lib.c
index 7ae6c293e518..a270f04588d7 100644
--- a/drivers/tty/hvc/hvsi_lib.c
+++ b/drivers/tty/hvc/hvsi_lib.c
@@ -405,8 +405,7 @@ void hvsilib_close(struct hvsi_priv *pv, struct hvc_struct *hp)
 		hvsi_send_close(pv);
 	}
 
-	if (pv->tty)
-		tty_kref_put(pv->tty);
+	tty_kref_put(pv->tty);
 	pv->tty = NULL;
 }