summary refs log tree commit diff
path: root/drivers/watchdog/wdrtas.c
diff options
context:
space:
mode:
authorHector Palacios <hector.palacios@digi.com>2013-04-08 17:06:32 +0200
committerWim Van Sebroeck <wim@iguana.be>2013-07-11 21:14:39 +0200
commitfcf95670fd29359a382e0755e573b36076d6283e (patch)
treef529d381c5f34de259208c52de6dcbd079f2a19a /drivers/watchdog/wdrtas.c
parent5f314970b25a6960dd056b0038ffc7b88dc2973e (diff)
downloadlinux-fcf95670fd29359a382e0755e573b36076d6283e.tar.gz
watchdog: core: don't try to stop device if not running
A watchdog device may be stopped from userspace using WDIOC_SETOPTIONS
ioctl and flag WDIOS_DISABLECARD. If the device is closed after this
operation, watchdog_release() is called and status bits checked for
stopping it. Besides, if the device has not been unregistered a critical
message "watchdog did not stop!" is printed, although the ioctl may have
successfully stopped it already.

Without the patch a user application sample code like this will successfully
stop the watchdog, but the kernel will output the message
"watchdog did not stop!":

	wd_fd = open("/dev/watchdog", O_RDWR);

	flags = WDIOS_DISABLECARD;
	ioctl(wd_fd, WDIOC_SETOPTIONS, &flags);

	close(wd_fd);

Signed-off-by: Hector Palacios <hector.palacios@digi.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
Diffstat (limited to 'drivers/watchdog/wdrtas.c')
0 files changed, 0 insertions, 0 deletions