diff options
author | Daniel De Graaf <dgdegra@tycho.nsa.gov> | 2010-08-10 18:02:45 -0700 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2010-08-11 08:59:12 -0700 |
commit | c07fbfd17e614a76b194f371c5331e21e6cffb54 (patch) | |
tree | 34bd53668b5b45b344411d49d8acf6d466004428 /drivers/video/chipsfb.c | |
parent | daf695fca877068d7533a1b431b09210e5ad0b6b (diff) | |
download | linux-c07fbfd17e614a76b194f371c5331e21e6cffb54.tar.gz |
fbmem: VM_IO set, but not propagated
When we setup up the VMA flags for the mmap flag and we end up using the fallback mmap functionality we set the vma->vm_flags |= VM_IO. However we neglect to propagate the flag to the vma->vm_page_prot. This bug was found when Linux kernel was running under Xen. In that scenario, any page that has VM_IO flag to it, means that it MUST be a MMIO/VRAM backend memory , _not_ System RAM. That is what the fbmem.c does: sets VM_IO, ioremaps the region - everything is peachy. Well, not exactly. The vm_page_prot does not get the relevant PTE flags set (_PAGE_IOMAP) which under Xen is a death-kneel to pages that are referencing real physical devices but don't have that flag set. This patch fixes this. Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> Signed-off-by: Daniel De Graaf <dgdegra@tycho.nsa.gov> Tested-by: Eamon Walsh <ewalsh@tycho.nsa.gov> Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de> Cc: Dave Airlie <airlied@linux.ie> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/video/chipsfb.c')
0 files changed, 0 insertions, 0 deletions