summary refs log tree commit diff
path: root/drivers/usb
diff options
context:
space:
mode:
authorFerry Toth <ftoth@exalondelft.nl>2022-12-22 21:53:02 +0100
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2023-01-18 11:58:33 +0100
commit86cd9d9ebda6460a2ec2c9e9e5970da12c6b8fce (patch)
treee9c7094dacb39e560798c37b3f2ca3c3ab489725 /drivers/usb
parent73a630b359c852d6edc113588c513ddbcd3be47a (diff)
downloadlinux-86cd9d9ebda6460a2ec2c9e9e5970da12c6b8fce.tar.gz
Revert "usb: ulpi: defer ulpi_register on ulpi_read_id timeout"
commit b659b613cea2ae39746ca8bd2b69d1985dd9d770 upstream.

This reverts commit 8a7b31d545d3a15f0e6f5984ae16f0ca4fd76aac.

This patch results in some qemu test failures, specifically xilinx-zynq-a9
machine and zynq-zc702 as well as zynq-zed devicetree files, when trying
to boot from USB drive.

Link: https://lore.kernel.org/lkml/20221220194334.GA942039@roeck-us.net/
Fixes: 8a7b31d545d3 ("usb: ulpi: defer ulpi_register on ulpi_read_id timeout")
Cc: stable@vger.kernel.org
Reported-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Ferry Toth <ftoth@exalondelft.nl>
Link: https://lore.kernel.org/r/20221222205302.45761-1-ftoth@exalondelft.nl
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb')
-rw-r--r--drivers/usb/common/ulpi.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/usb/common/ulpi.c b/drivers/usb/common/ulpi.c
index 60e8174686a1..d7c8461976ce 100644
--- a/drivers/usb/common/ulpi.c
+++ b/drivers/usb/common/ulpi.c
@@ -207,7 +207,7 @@ static int ulpi_read_id(struct ulpi *ulpi)
 	/* Test the interface */
 	ret = ulpi_write(ulpi, ULPI_SCRATCH, 0xaa);
 	if (ret < 0)
-		return ret;
+		goto err;
 
 	ret = ulpi_read(ulpi, ULPI_SCRATCH);
 	if (ret < 0)