summary refs log tree commit diff
path: root/drivers/usb/dwc2/hcd.h
diff options
context:
space:
mode:
authorGuenter Roeck <linux@roeck-us.net>2019-05-29 13:54:43 -0700
committerFelipe Balbi <felipe.balbi@linux.intel.com>2019-06-18 11:58:29 +0300
commitad408a1596b45868e38d0504f2ec1d5fb06f17d4 (patch)
treeba6621a5a349b71859927468e82711567775447b /drivers/usb/dwc2/hcd.h
parentd78cc1a4b72a455ae53c434ddb8835035a332c5b (diff)
downloadlinux-ad408a1596b45868e38d0504f2ec1d5fb06f17d4.tar.gz
Revert "usb: dwc2: host: Setting qtd to NULL after freeing it"
This reverts commit b0d659022e5c96ee5c4bd62d22d3da2d66de306b.

The reverted commit does nothing but adding two unnecessary lines
of code.  It sets a local variable to NULL in two functions, but
that variable is not used anywhere in the rest of those functions.
This is just confusing, so let's remove it.

Cc: Vardan Mikayelyan <mvardan@synopsys.com>
Cc: John Youn <johnyoun@synopsys.com>
Cc: Douglas Anderson <dianders@chromiun.org>
Cc: Felipe Balbi <felipe.balbi@linux.intel.com>
Acked-by: Minas Harutyunyan <hminas@synopsys.com>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
Diffstat (limited to 'drivers/usb/dwc2/hcd.h')
-rw-r--r--drivers/usb/dwc2/hcd.h1
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/usb/dwc2/hcd.h b/drivers/usb/dwc2/hcd.h
index ce6445a06588..8ca6d12a6f57 100644
--- a/drivers/usb/dwc2/hcd.h
+++ b/drivers/usb/dwc2/hcd.h
@@ -582,7 +582,6 @@ static inline void dwc2_hcd_qtd_unlink_and_free(struct dwc2_hsotg *hsotg,
 {
 	list_del(&qtd->qtd_list_entry);
 	kfree(qtd);
-	qtd = NULL;
 }
 
 /* Descriptor DMA support functions */