diff options
| author | Jiri Slaby <jslaby@suse.cz> | 2021-11-18 08:31:15 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-11-25 18:33:21 +0100 |
| commit | 467b4c47880dc8aaf26e31262d19271674fa862a (patch) | |
| tree | 0bc2cdc76238d3fc7c642aa14cf2cbce68494b2d /drivers/tty/mxser.c | |
| parent | 47b722d473824e9c56b7487d47ea7423483258d9 (diff) | |
| download | linux-467b4c47880dc8aaf26e31262d19271674fa862a.tar.gz | |
mxser: don't flush buffer from mxser_close() directly
I fail to see the point of calling mxser_flush_buffer() from mxser_close(): 1) The SW xmit buffer is freed in mxser_shutdown_port() right after the call to mxser_flush_buffer(). And all 'cnt', 'head', and 'tail' are properly initialized to 0 in mxser_activate(). 2) The HW buffer is flushed in mxser_shutdown_port() via mxser_disable_and_clear_FIFO() too. So the effect of doing it by mxser_flush_buffer() in mxser_close() is none. Hence remove it, so that when we use tty_port_close() later, the code is 1:1 identical. Signed-off-by: Jiri Slaby <jslaby@suse.cz> Link: https://lore.kernel.org/r/20211118073125.12283-10-jslaby@suse.cz Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/tty/mxser.c')
| -rw-r--r-- | drivers/tty/mxser.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/tty/mxser.c b/drivers/tty/mxser.c index 45ee1122a5f7..4dafa16aa29c 100644 --- a/drivers/tty/mxser.c +++ b/drivers/tty/mxser.c @@ -910,7 +910,6 @@ static void mxser_close(struct tty_struct *tty, struct file *filp) if (tty_port_close_start(port, tty, filp) == 0) return; mutex_lock(&port->mutex); - mxser_flush_buffer(tty); if (tty_port_initialized(port) && C_HUPCL(tty)) tty_port_lower_dtr_rts(port); mxser_shutdown_port(port); |