diff options
| author | Himangi Saraogi <himangi774@gmail.com> | 2014-07-17 02:29:53 +0530 |
|---|---|---|
| committer | Nicholas Bellinger <nab@linux-iscsi.org> | 2014-09-15 14:20:00 -0700 |
| commit | e1ea97fef0cd579fd7ef3851548e068eaf2ad9f0 (patch) | |
| tree | f4b6a173ae8defceececc6e86d5675f6d22dfe1a /drivers/target | |
| parent | 9e82bf014195d6f0054982c463575cdce24292be (diff) | |
| download | linux-e1ea97fef0cd579fd7ef3851548e068eaf2ad9f0.tar.gz | |
target/configfs: Remove unnecessary null test
This patch removes the null test on lun_cg. lun_cg is initialized at the beginning of the function to &lun->lun_group. Since lun_cg is dereferenced prior to the null test, it must be a valid pointer. The following Coccinelle script is used for detecting the change: @r@ expression e,f; identifier g,y; statement S1,S2; @@ *e = &f->g <+... f->y ...+> *if (e != NULL || ...) S1 else S2 Signed-off-by: Himangi Saraogi <himangi774@gmail.com> Acked-by: Julia Lawall <julia.lawall@lip6.fr> Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Diffstat (limited to 'drivers/target')
| -rw-r--r-- | drivers/target/target_core_fabric_configfs.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/target/target_core_fabric_configfs.c b/drivers/target/target_core_fabric_configfs.c index 7de9f0475d05..7228a18b12ad 100644 --- a/drivers/target/target_core_fabric_configfs.c +++ b/drivers/target/target_core_fabric_configfs.c @@ -917,8 +917,7 @@ static struct config_group *target_fabric_make_lun( return &lun->lun_group; out: - if (lun_cg) - kfree(lun_cg->default_groups); + kfree(lun_cg->default_groups); return ERR_PTR(errno); } |