diff options
| author | Jakob Koschel <jakobkoschel@gmail.com> | 2022-03-24 08:25:34 +0100 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2022-04-05 10:21:55 +0100 |
| commit | d50d7e91c6e5ccd71f21ba1aec3fef7ee4229fd6 (patch) | |
| tree | 71c022e619f8aaebf43d889f0cc14f16fb5cdab5 /drivers/spi/spidev.c | |
| parent | 02b3024824f48a270f6170901f1abeb1edb1619f (diff) | |
| download | linux-d50d7e91c6e5ccd71f21ba1aec3fef7ee4229fd6.tar.gz | |
spi: spidev: replace usage of found with dedicated list iterator variable
To move the list iterator variable into the list_for_each_entry_*() macro in the future it should be avoided to use the list iterator variable after the loop body. To *never* use the list iterator variable after the loop it was concluded to use a separate iterator variable instead of a found boolean [1]. This removes the need to use a found variable and simply checking if the variable was set, can determine if the break/goto was hit. Link: https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@mail.gmail.com/ Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com> Link: https://lore.kernel.org/r/20220324072534.63420-1-jakobkoschel@gmail.com Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/spi/spidev.c')
| -rw-r--r-- | drivers/spi/spidev.c | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/drivers/spi/spidev.c b/drivers/spi/spidev.c index ba4649f06871..b2cefe93b3a0 100644 --- a/drivers/spi/spidev.c +++ b/drivers/spi/spidev.c @@ -568,19 +568,20 @@ spidev_compat_ioctl(struct file *filp, unsigned int cmd, unsigned long arg) static int spidev_open(struct inode *inode, struct file *filp) { - struct spidev_data *spidev; + struct spidev_data *spidev = NULL, *iter; int status = -ENXIO; mutex_lock(&device_list_lock); - list_for_each_entry(spidev, &device_list, device_entry) { - if (spidev->devt == inode->i_rdev) { + list_for_each_entry(iter, &device_list, device_entry) { + if (iter->devt == inode->i_rdev) { status = 0; + spidev = iter; break; } } - if (status) { + if (!spidev) { pr_debug("spidev: nothing for minor %d\n", iminor(inode)); goto err_find_dev; } |