diff options
| author | Miaoqian Lin <linmq006@gmail.com> | 2022-12-31 13:58:48 +0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2023-02-01 08:34:05 +0100 |
| commit | 9eea16953ec1c66b4ad58dd8ecb056e1b4f8681c (patch) | |
| tree | a1adc5426b0143dd2b6cbfd1691b522251d27742 /drivers/soc | |
| parent | c47e53679af1d2ad60607f521b385f0d7c5654e8 (diff) | |
| download | linux-9eea16953ec1c66b4ad58dd8ecb056e1b4f8681c.tar.gz | |
soc: imx8m: Fix incorrect check for of_clk_get_by_name()
[ Upstream commit 490748874ebf1875420fc29b335bba2075dd1b5e ]
of_clk_get_by_name() returns error pointers instead of NULL.
Use IS_ERR() checks the return value to catch errors.
Fixes: 836fb30949d9 ("soc: imx8m: Enable OCOTP clock before reading the register")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: Shawn Guo <shawnguo@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/soc')
| -rw-r--r-- | drivers/soc/imx/soc-imx8m.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/soc/imx/soc-imx8m.c b/drivers/soc/imx/soc-imx8m.c index 28144c699b0c..32ed9dc88e45 100644 --- a/drivers/soc/imx/soc-imx8m.c +++ b/drivers/soc/imx/soc-imx8m.c @@ -66,8 +66,8 @@ static u32 __init imx8mq_soc_revision(void) ocotp_base = of_iomap(np, 0); WARN_ON(!ocotp_base); clk = of_clk_get_by_name(np, NULL); - if (!clk) { - WARN_ON(!clk); + if (IS_ERR(clk)) { + WARN_ON(IS_ERR(clk)); return 0; } |