summary refs log tree commit diff
path: root/drivers/scsi/vmw_pvscsi.h
diff options
context:
space:
mode:
authorDavid Jeffery <djeffery@redhat.com>2016-10-28 12:27:26 -0400
committerMartin K. Petersen <martin.petersen@oracle.com>2016-11-01 13:31:23 -0400
commitaac173e9618faadf8f92af6cc05e64f7acc64d79 (patch)
tree2b1145a0b142843a566dac4221bf9e385896bc44 /drivers/scsi/vmw_pvscsi.h
parent6d3a56ed098566bc83d6c2afa74b4199c12ea074 (diff)
downloadlinux-aac173e9618faadf8f92af6cc05e64f7acc64d79.tar.gz
scsi: vmw_pvscsi: return SUCCESS for successful command aborts
The vmw_pvscsi driver reports most successful aborts as FAILED to the
scsi error handler.  This is do to a misunderstanding of how
completion_done() works and its interaction with a successful wait using
wait_for_completion_timeout().  The vmw_pvscsi driver is expecting
completion_done() to always return true if complete() has been called on
the completion structure.  But completion_done() returns true after
complete() has been called only if no function like
wait_for_completion_timeout() has seen the completion and cleared it as
part of successfully waiting for the completion.

Instead of using completion_done(), vmw_pvscsi should just use the
return value from wait_for_completion_timeout() to know if the wait
timed out or not.

[mkp: bumped driver version per request]

Signed-off-by: David Jeffery <djeffery@redhat.com>
Reviewed-by: Laurence Oberman <loberman@redhat.com>
Reviewed-by: Ewan D. Milne <emilne@redhat.com>
Acked-by: Jim Gill <jgill@vmware.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/scsi/vmw_pvscsi.h')
-rw-r--r--drivers/scsi/vmw_pvscsi.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/scsi/vmw_pvscsi.h b/drivers/scsi/vmw_pvscsi.h
index c097d2ccbde3..d41292ef85f2 100644
--- a/drivers/scsi/vmw_pvscsi.h
+++ b/drivers/scsi/vmw_pvscsi.h
@@ -26,7 +26,7 @@
 
 #include <linux/types.h>
 
-#define PVSCSI_DRIVER_VERSION_STRING   "1.0.6.0-k"
+#define PVSCSI_DRIVER_VERSION_STRING   "1.0.7.0-k"
 
 #define PVSCSI_MAX_NUM_SG_ENTRIES_PER_SEGMENT 128