summary refs log tree commit diff
path: root/drivers/scsi/lpfc/lpfc_els.c
diff options
context:
space:
mode:
authorChristoph Hellwig <hch@lst.de>2019-12-03 10:39:08 +0100
committerJens Axboe <axboe@kernel.dk>2019-12-03 10:18:22 -0700
commit6c6b3549142255c3fe4bab5560efdf8391c8d858 (patch)
tree0a738d6947054942fedcd44f532d6579976c1c28 /drivers/scsi/lpfc/lpfc_els.c
parentae58954d8734c44298f55ed71e683ea944994fab (diff)
downloadlinux-6c6b3549142255c3fe4bab5560efdf8391c8d858.tar.gz
block: set the zone size in blk_revalidate_disk_zones atomically
The current zone revalidation code has a major problem in that it
doesn't update the zone size and q->nr_zones atomically, leading
to a short window where an out of bounds access to the zone arrays
is possible.

To fix this move the setting of the zone size into the crticial
sections blk_revalidate_disk_zones so that it gets updated together
with the zone bitmaps and q->nr_zones.  This also slightly simplifies
the caller as it deducts the zone size from the report_zones.

This change also allows to check for a power of two zone size in generic
code.

Reported-by: Hans Holmberg <hans@owltronix.com>
Reviewed-by: Javier González <javier@javigon.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'drivers/scsi/lpfc/lpfc_els.c')
0 files changed, 0 insertions, 0 deletions