summary refs log tree commit diff
path: root/drivers/ptp/ptp_chardev.c
diff options
context:
space:
mode:
authorGustavo A. R. Silva <gustavo@embeddedor.com>2018-07-17 20:17:33 -0500
committerDavid S. Miller <davem@davemloft.net>2018-07-18 15:25:25 -0700
commit9ba8376ce1e2cbf4ce44f7e4bee1d0648e10d594 (patch)
tree31483ce274788fcc3c4ef1ae8faa4895c329aa65 /drivers/ptp/ptp_chardev.c
parent6b81b193b83e87da1ea13217d684b54fccf8ee8a (diff)
downloadlinux-9ba8376ce1e2cbf4ce44f7e4bee1d0648e10d594.tar.gz
ptp: fix missing break in switch
It seems that a *break* is missing in order to avoid falling through
to the default case. Otherwise, checking *chan* makes no sense.

Fixes: 72df7a7244c0 ("ptp: Allow reassigning calibration pin function")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Acked-by: Richard Cochran <richardcochran@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/ptp/ptp_chardev.c')
-rw-r--r--drivers/ptp/ptp_chardev.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/ptp/ptp_chardev.c b/drivers/ptp/ptp_chardev.c
index 547dbdac9d54..01b0e2bb3319 100644
--- a/drivers/ptp/ptp_chardev.c
+++ b/drivers/ptp/ptp_chardev.c
@@ -89,6 +89,7 @@ int ptp_set_pinfunc(struct ptp_clock *ptp, unsigned int pin,
 	case PTP_PF_PHYSYNC:
 		if (chan != 0)
 			return -EINVAL;
+		break;
 	default:
 		return -EINVAL;
 	}