diff options
| author | Qi Zheng <zhengqi.arch@bytedance.com> | 2023-02-08 12:00:37 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2023-03-10 09:33:01 +0100 |
| commit | 02c90e03e64fb72dee0d372d71e7602bde6aa66f (patch) | |
| tree | 8cbf5c13801661e4d0893aa55586d882f133f012 /drivers/opp | |
| parent | 035a80733ec47ed81aa159e16e56d2de106d3335 (diff) | |
| download | linux-02c90e03e64fb72dee0d372d71e7602bde6aa66f.tar.gz | |
OPP: fix error checking in opp_migrate_dentry()
[ Upstream commit eca4c0eea53432ec4b711b2a8ad282cbad231b4f ]
Since commit ff9fb72bc077 ("debugfs: return error values,
not NULL") changed return value of debugfs_rename() in
error cases from %NULL to %ERR_PTR(-ERROR), we should
also check error values instead of NULL.
Fixes: ff9fb72bc077 ("debugfs: return error values, not NULL")
Signed-off-by: Qi Zheng <zhengqi.arch@bytedance.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/opp')
| -rw-r--r-- | drivers/opp/debugfs.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/opp/debugfs.c b/drivers/opp/debugfs.c index 96a30a032c5f..2c7fb683441e 100644 --- a/drivers/opp/debugfs.c +++ b/drivers/opp/debugfs.c @@ -235,7 +235,7 @@ static void opp_migrate_dentry(struct opp_device *opp_dev, dentry = debugfs_rename(rootdir, opp_dev->dentry, rootdir, opp_table->dentry_name); - if (!dentry) { + if (IS_ERR(dentry)) { dev_err(dev, "%s: Failed to rename link from: %s to %s\n", __func__, dev_name(opp_dev->dev), dev_name(dev)); return; |