summary refs log tree commit diff
path: root/drivers/of
diff options
context:
space:
mode:
authorRob Herring <robh@kernel.org>2017-05-04 12:34:30 -0500
committerRob Herring <robh@kernel.org>2017-05-04 12:58:48 -0500
commiteb3100365791b06242b8bb5c3c2854ba41dabfbc (patch)
treef2fb4e03e436f078ebfb85d8c69f358b03bb79ae /drivers/of
parent91d967497f11dbb5038c7b84bc30dae684ae5ffb (diff)
downloadlinux-eb3100365791b06242b8bb5c3c2854ba41dabfbc.tar.gz
of: fix sparse warning in of_pci_range_parser_one
sparse gives the following warning for 'pci_space':

../drivers/of/address.c:266:26: warning: incorrect type in assignment (different base types)
../drivers/of/address.c:266:26:    expected unsigned int [unsigned] [usertype] pci_space
../drivers/of/address.c:266:26:    got restricted __be32 const [usertype] <noident>

It appears that pci_space is only ever accessed on powerpc, so the endian
swap is often not needed.

Cc: stable@vger.kernel.org
Signed-off-by: Rob Herring <robh@kernel.org>
Diffstat (limited to 'drivers/of')
-rw-r--r--drivers/of/address.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/of/address.c b/drivers/of/address.c
index 02b2903fe9d2..72914cdfce2a 100644
--- a/drivers/of/address.c
+++ b/drivers/of/address.c
@@ -263,7 +263,7 @@ struct of_pci_range *of_pci_range_parser_one(struct of_pci_range_parser *parser,
 	if (!parser->range || parser->range + parser->np > parser->end)
 		return NULL;
 
-	range->pci_space = parser->range[0];
+	range->pci_space = be32_to_cpup(parser->range);
 	range->flags = of_bus_pci_get_flags(parser->range);
 	range->pci_addr = of_read_number(parser->range + 1, ns);
 	range->cpu_addr = of_translate_address(parser->node,