diff options
| author | Sukadev Bhattiprolu <sukadev@linux.ibm.com> | 2022-02-24 22:23:52 -0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2022-02-25 10:57:47 +0000 |
| commit | 765559b10ce514eb1576595834f23cdc92125fee (patch) | |
| tree | 6b30a558176da73758b54e2626f422d1db7bd7d4 /drivers/net/ethernet/ibm/ibmvnic.c | |
| parent | 8d0657f39f487d904fca713e0bc39c2707382553 (diff) | |
| download | linux-765559b10ce514eb1576595834f23cdc92125fee.tar.gz | |
ibmvnic: initialize rc before completing wait
We should initialize ->init_done_rc before calling complete(). Otherwise
the waiting thread may see ->init_done_rc as 0 before we have updated it
and may assume that the CRQ was successful.
Fixes: 6b278c0cb378 ("ibmvnic delay complete()")
Signed-off-by: Sukadev Bhattiprolu <sukadev@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/ibm/ibmvnic.c')
| -rw-r--r-- | drivers/net/ethernet/ibm/ibmvnic.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c index 86d522171892..c73c699600a8 100644 --- a/drivers/net/ethernet/ibm/ibmvnic.c +++ b/drivers/net/ethernet/ibm/ibmvnic.c @@ -5323,9 +5323,9 @@ static void ibmvnic_handle_crq(union ibmvnic_crq *crq, } if (!completion_done(&adapter->init_done)) { - complete(&adapter->init_done); if (!adapter->init_done_rc) adapter->init_done_rc = -EAGAIN; + complete(&adapter->init_done); } break; |