summary refs log tree commit diff
path: root/drivers/mtd/maps/sa1100-flash.c
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2016-07-15 14:06:30 +0300
committerBrian Norris <computersforpeace@gmail.com>2016-07-15 18:40:25 -0700
commitdc01a28d80a42cef08c94dfc595565aaebe46d15 (patch)
treed40529045d5a1cfcc3301ef37bcb2016485894b1 /drivers/mtd/maps/sa1100-flash.c
parent161aaab8a067a96b686e2429a72bfd92f6aaf363 (diff)
downloadlinux-dc01a28d80a42cef08c94dfc595565aaebe46d15.tar.gz
mtd: maps: sa1100-flash: potential NULL dereference
We check for NULL but then dereference "info->mtd" on the next line.

Fixes: 72169755cf36 ('mtd: maps: sa1100-flash: show parent device in sysfs')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Diffstat (limited to 'drivers/mtd/maps/sa1100-flash.c')
-rw-r--r--drivers/mtd/maps/sa1100-flash.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/mtd/maps/sa1100-flash.c b/drivers/mtd/maps/sa1100-flash.c
index 142fc3d79463..784c6e1a0391 100644
--- a/drivers/mtd/maps/sa1100-flash.c
+++ b/drivers/mtd/maps/sa1100-flash.c
@@ -230,8 +230,10 @@ static struct sa_info *sa1100_setup_mtd(struct platform_device *pdev,
 
 		info->mtd = mtd_concat_create(cdev, info->num_subdev,
 					      plat->name);
-		if (info->mtd == NULL)
+		if (info->mtd == NULL) {
 			ret = -ENXIO;
+			goto err;
+		}
 	}
 	info->mtd->dev.parent = &pdev->dev;