summary refs log tree commit diff
path: root/drivers/mmc/core
diff options
context:
space:
mode:
authorArnd Bergmann <arnd@arndb.de>2016-01-13 22:25:41 +0100
committerUlf Hansson <ulf.hansson@linaro.org>2016-01-14 11:00:29 +0100
commitd50f42384dbfcf5143de614710e132dc06cd2439 (patch)
treea47cb5297cd8b7481b5d5496e8915fac2bac6f00 /drivers/mmc/core
parente10c321977091f163eceedec0650e0ef4b3cf4bb (diff)
downloadlinux-d50f42384dbfcf5143de614710e132dc06cd2439.tar.gz
mmc: tmio_mmc_dma: don't print invalid DMA cookie
The tmio_mmc_start_dma_{rx,tx} function functions contain debug
code that prints the dma cookie among other things. However,
in case we fall back to PIO mode for some reason, the cookie
variable is never initialized, and gcc warns about this:

In file included from ../include/linux/printk.h:277:0,
                 from ../include/linux/kernel.h:13,
                 from ../include/linux/list.h:8,
                 from ../include/linux/kobject.h:20,
                 from ../include/linux/device.h:17,
                 from ../drivers/mmc/host/tmio_mmc_dma.c:13:
../drivers/mmc/host/tmio_mmc_dma.c: In function 'tmio_mmc_start_dma':
../include/linux/dynamic_debug.h:86:3: warning: 'cookie' may be used uninitialized in this function [-Wmaybe-uninitialized]
   __dynamic_dev_dbg(&descriptor, dev, fmt, \
   ^
../drivers/mmc/host/tmio_mmc_dma.c:128:15: note: 'cookie' was declared here
  dma_cookie_t cookie;

This modifies the dev_dbg() statements so we only print the cookie
when we are already in the DMA path.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Diffstat (limited to 'drivers/mmc/core')
0 files changed, 0 insertions, 0 deletions