summary refs log tree commit diff
path: root/drivers/misc/ti-st
diff options
context:
space:
mode:
authorColin Ian King <colin.king@canonical.com>2018-11-29 23:15:56 +0000
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2018-12-06 15:53:15 +0100
commit4b4bdfe7d4a02a5c88ec242e3469cb81e00f1f34 (patch)
tree69fa9b6176c13ec169a6a315dcd1cb0ec19f01c1 /drivers/misc/ti-st
parent649ad1165ac17521c062022a0caf8f0eea71f881 (diff)
downloadlinux-4b4bdfe7d4a02a5c88ec242e3469cb81e00f1f34.tar.gz
misc: ti-st: make array read_ver_cmd static, shrinks object size
Don't populate the const array read_ver_cmd on the stack but instead
make it static. Makes the object code smaller by 42 bytes:

Before:
   text	   data	    bss	    dec	    hex	filename
  17262	   6928	    192	  24382	   5f3e	drivers/misc/ti-st/st_kim.o

After:
   text	   data	    bss	    dec	    hex	filename
  17156	   6992	    192	  24340	   5f14	drivers/misc/ti-st/st_kim.o

(gcc version 8.2.0 x86_64)

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/misc/ti-st')
-rw-r--r--drivers/misc/ti-st/st_kim.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/misc/ti-st/st_kim.c b/drivers/misc/ti-st/st_kim.c
index e47abf173626..e7cfdbd1f66d 100644
--- a/drivers/misc/ti-st/st_kim.c
+++ b/drivers/misc/ti-st/st_kim.c
@@ -211,7 +211,7 @@ static void kim_int_recv(struct kim_data_s *kim_gdata,
 static long read_local_version(struct kim_data_s *kim_gdata, char *bts_scr_name)
 {
 	unsigned short version = 0, chip = 0, min_ver = 0, maj_ver = 0;
-	const char read_ver_cmd[] = { 0x01, 0x01, 0x10, 0x00 };
+	static const char read_ver_cmd[] = { 0x01, 0x01, 0x10, 0x00 };
 	long timeout;
 
 	pr_debug("%s", __func__);