summary refs log tree commit diff
path: root/drivers/media/video/cx18/cx18-io.h
diff options
context:
space:
mode:
authorAndy Walls <awalls@radix.net>2008-11-02 18:15:28 -0300
committerMauro Carvalho Chehab <mchehab@redhat.com>2008-12-30 09:38:00 -0200
commitf7823f8f437fbbd41155f2312ef17e471199b706 (patch)
tree245f1a91956f553ce387e6caa10c875b3f4316c4 /drivers/media/video/cx18/cx18-io.h
parentf2e52cd17622eed39576f113b77bbd18c577e308 (diff)
downloadlinux-f7823f8f437fbbd41155f2312ef17e471199b706.tar.gz
V4L/DVB (9513): cx18: Reduce number of mmio read retries
cx18: Reduce number of mmio read retries to improve performance.  Experiments
have shown 2 things: read retries never improve the result of a suspect mmio
read from the CX23418 (the result stays all 0xff's), and that most of the
suspected read failures are actually proper reads of values that should be
all 0xff's.  This change reduces the number of read retries and keeps the
count separate from write retries.

Signed-off-by: Andy Walls <awalls@radix.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/video/cx18/cx18-io.h')
-rw-r--r--drivers/media/video/cx18/cx18-io.h8
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/media/video/cx18/cx18-io.h b/drivers/media/video/cx18/cx18-io.h
index 425244453ea7..cb695a59670d 100644
--- a/drivers/media/video/cx18/cx18-io.h
+++ b/drivers/media/video/cx18/cx18-io.h
@@ -41,8 +41,8 @@ static inline void cx18_io_delay(struct cx18 *cx)
 static inline
 void cx18_log_write_retries(struct cx18 *cx, int i, const void __iomem *addr)
 {
-	if (i > CX18_MAX_MMIO_RETRIES)
-		i = CX18_MAX_MMIO_RETRIES;
+	if (i > CX18_MAX_MMIO_WR_RETRIES)
+		i = CX18_MAX_MMIO_WR_RETRIES;
 	atomic_inc(&cx->mmio_stats.retried_write[i]);
 	return;
 }
@@ -50,8 +50,8 @@ void cx18_log_write_retries(struct cx18 *cx, int i, const void __iomem *addr)
 static inline
 void cx18_log_read_retries(struct cx18 *cx, int i, const void __iomem *addr)
 {
-	if (i > CX18_MAX_MMIO_RETRIES)
-		i = CX18_MAX_MMIO_RETRIES;
+	if (i > CX18_MAX_MMIO_RD_RETRIES)
+		i = CX18_MAX_MMIO_RD_RETRIES;
 	atomic_inc(&cx->mmio_stats.retried_read[i]);
 	return;
 }